Skip to content

fix(Typing): change NodeJS.Timer into NodeJS.Timeout #4755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2020
Merged

fix(Typing): change NodeJS.Timer into NodeJS.Timeout #4755

merged 1 commit into from
Aug 29, 2020
+10 −10

Conversation

tguichaoua
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
fix #4754

Using NodeJS.Timeout is more relevant than NodeJS.Timer.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

Sorry, something went wrong.

@iCrawl iCrawl requested review from vladfrangu and kyranet August 29, 2020 10:09
@iCrawl iCrawl merged commit 405b487 into discordjs:master Aug 29, 2020
@tguichaoua tguichaoua deleted the fix-type branch August 29, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu

@iCrawl iCrawl

@kyranet kyranet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use NodeJS.Timeout instead of NodeJS.Timer
4 participants
@tguichaoua @vladfrangu @iCrawl @kyranet