Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly import extendable classes #4744

Merged
merged 7 commits into from Aug 28, 2020
Merged

Conversation

NotSugden
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
fixes #4742
This PR changes the GuildMember and User classes to import Presence (and VoiceState on GuildMember) using Structures.get(...) rather than a require import, to correct instantiate any custom extended class

Notes: the NewsChannel and ClientPresence classes seem to not extend TextChannel and NewsChannel respectively, but i wasn't sure the best way to go about fixing that, so i've left it for now

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@iCrawl iCrawl merged commit 6aab9c3 into discordjs:master Aug 28, 2020
@NotSugden NotSugden deleted the patch-16 branch September 14, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extending Presence doesn't affect all members?
5 participants