Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Client): allow options for generateInvite #4741

Merged
merged 5 commits into from Aug 28, 2020

Conversation

NotSugden
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
This PR deprecates the old method of passing a PermissionResolvable into Client#generateInvite and instead allows an object of options to be provided consisting of permissions, guild, and disableGuildSelect, (API Docs reference)

Wasn't sure about adding redirect_uri seeing as its not apart of the bot authorisation flow
Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • [ ] This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

src/client/Client.js Outdated Show resolved Hide resolved
@iCrawl iCrawl merged commit 727b29c into discordjs:master Aug 28, 2020
@NotSugden NotSugden deleted the patch-15 branch September 14, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants