Fix(Structure): Message#delete() cause event messageDelete to fires twice #3252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amishshah
approved these changes
May 7, 2019
Fyko
approved these changes
May 8, 2019
This was referenced May 17, 2019
Merged
SpaceEEC
approved these changes
Aug 17, 2019
samsamson33
pushed a commit
to samsamson33/discord.js
that referenced
this pull request
Feb 27, 2020
…iscordjs#3252) * ref: add getPayload and use for other get* methods * return existing data.* * use Action.getUser() * Fix messageDelete double emission
samsamson33
added a commit
to samsamson33/discord.js
that referenced
this pull request
Feb 27, 2020
…e twice (discordjs#3252)" This reverts commit e367c85.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #3250 should be merged before this PR
Please describe the changes this PR makes and why it should be merged:
When a message was deleted using the method
Message#delete(), the MessageDelete action handler was executed by it.After that, the MessageDelete action handler got executed again by the WebSocketManager.
Causing double emission.
The same problem can be found in
TextBasedChannel#bulkDelete()but I was unable to fix it due to lack of time.Status
Semantic versioning classification: