Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structures.extend checks the prototype chain #3217

Merged
merged 1 commit into from Apr 21, 2019
Merged

Structures.extend checks the prototype chain #3217

merged 1 commit into from Apr 21, 2019

Conversation

Dragoteryx
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
Fixes #3215.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@Dragoteryx
better prototype check
d9e0d07 
Checks the prototype chain.
bdistin
bdistin approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@bdistin bdistin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SpaceEEC SpaceEEC merged commit 52b4f09 into discordjs:master Apr 21, 2019
samsamson33 pushed a commit to samsamson33/discord.js that referenced this pull request Feb 27, 2020
@Dragoteryx @samsamson33
fix(Structures): allow multiple extensions by checking prototype chain (
33ede42 
discordjs#3217)
samsamson33 added a commit to samsamson33/discord.js that referenced this pull request Feb 27, 2020
@samsamson33
Revert "fix(Structures): allow multiple extensions by checking protot…
4c95561 
…ype chain (discordjs#3217)"

This reverts commit 33ede42.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdistin bdistin bdistin approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Structures.extend doesn't search the prototype chain
3 participants
@Dragoteryx @bdistin @SpaceEEC