fix(PresenceUpdateAction): emit presences again #3214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moonstar-x
added a commit
to moonstar-x/discord-downtime-notifier
that referenced
this pull request
Apr 19, 2019
Currently this feature doesn't properly work because of the discord.js library, it seems there's a bug that makes oldMember and newMember inside the presenceUpdate event handler have the same presence. discordjs/discord.js#3214
1 task
samsamson33
pushed a commit
to samsamson33/discord.js
that referenced
this pull request
Feb 27, 2020
* fix(PresenceUpdateAction): emit presences again * update typings
samsamson33
added a commit
to samsamson33/discord.js
that referenced
this pull request
Feb 27, 2020
…)" This reverts commit 7772717.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This probably was accidentally "reverted" by #2902 (version before merge here).
This caused
GuildMember#presenceforoldMembers to be the updated presence asGuildMember#frozenPresencewas removed from the getter previously.This PR fixes #3207 by emitting presences again.
Status
Semantic versioning classification: