Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use StringResolvable in Util.splitMessage #3212

Merged
merged 1 commit into from Apr 21, 2019
Merged

Use StringResolvable in Util.splitMessage #3212

merged 1 commit into from Apr 21, 2019

Conversation

Purpzie
Copy link
Contributor

@Purpzie Purpzie commented Apr 16, 2019 •
edited

Please describe the changes this PR makes and why it should be merged:
Changes Util.splitMessage to allow a StringResolvable to be passed in instead of just a string, just a super tiny but useful improvement. I noticed that MessageEmbed had this in most of its methods and it would be great for this too.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@SpaceEEC SpaceEEC merged commit abd9d36 into discordjs:master Apr 21, 2019
@Purpzie Purpzie mentioned this pull request Oct 29, 2019
Merged
5 tasks
iCrawl pushed a commit that referenced this pull request Nov 4, 2019
@Purpzie @iCrawl
typings(Util): use StringResolvable (fixes old pull) (#3556)
99466a9 
Fixes my extremely old pull #3212 that didn't actually update the typing (Didn't know at the time.)
samsamson33 pushed a commit to samsamson33/discord.js that referenced this pull request Feb 27, 2020
@Purpzie @samsamson33
feat(Util): resolve text parameter of splitMessage to a string (disco…
6e230b9 
…rdjs#3212)
samsamson33 pushed a commit to samsamson33/discord.js that referenced this pull request Feb 27, 2020
@Purpzie @samsamson33
typings(Util): use StringResolvable (fixes old pull) (discordjs#3556)
1ec929d 
Fixes my extremely old pull discordjs#3212 that didn't actually update the typing (Didn't know at the time.)
samsamson33 added a commit to samsamson33/discord.js that referenced this pull request Feb 27, 2020
@samsamson33
Revert "feat(Util): resolve text parameter of splitMessage to a string (
bab9bc5 
discordjs#3212)"

This reverts commit 6e230b9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Purpzie @SpaceEEC