feat(Sharding): Change waitForReady to spawnTimeout
#3080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that you'll not only be able to choose between having a timeout or not, but also to set the amount of milliseconds as you wish.
|
Good idea imo, as some of my shards are taking more than 30 seconds to be ready. |
|
Thanks you! Would you like to help me testing the changes? 😄 |
SpaceEEC
approved these changes
Apr 21, 2019
samsamson33
pushed a commit
to samsamson33/discord.js
that referenced
this pull request
Feb 27, 2020
This means that you'll not only be able to choose between having a timeout or not, but also to set the amount of milliseconds as you wish.
samsamson33
added a commit
to samsamson33/discord.js
that referenced
this pull request
Feb 27, 2020
…ordjs#3080)" This reverts commit 68e2a23.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This means that you'll not only be able to choose between having a timeout or not, but also to set the amount of milliseconds as you wish.
Status
Semantic versioning classification: