Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(User): add avatarDecorationData #9888

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Oct 15, 2023

Please describe the changes this PR makes and why it should be merged:
Upstream:

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Oct 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2023 1:20am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2023 1:20am

@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (571aedd) 60.06% compared to head (e1b8054) 60.28%.
Report is 159 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9888      +/-   ##
==========================================
+ Coverage   60.06%   60.28%   +0.21%     
==========================================
  Files         235      235              
  Lines       16020    16106      +86     
  Branches     1215     1219       +4     
==========================================
+ Hits         9623     9710      +87     
+ Misses       6353     6351       -2     
- Partials       44       45       +1     
Flag Coverage Δ
next ∅ <ø> (∅)
proxy 75.00% <ø> (-1.32%) ⬇️
rest 93.17% <100.00%> (+0.40%) ⬆️
ws 52.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@almeidx almeidx force-pushed the discord.js/avatar-decoration-presets branch from 90c1fc3 to 88e85b6 Compare October 15, 2023 19:19
@github-actions
Copy link

github-actions bot commented Oct 15, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 68
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 67
🔴 PWA 33

Lighthouse ran on https://discord-js-guide-git-discordjs-avatar-decorati-739fa9-discordjs.vercel.app/

@Jiralite Jiralite removed this from the discord.js 14.15 milestone Oct 19, 2023
@almeidx almeidx force-pushed the discord.js/avatar-decoration-presets branch from 79bbcd1 to 1e1c732 Compare October 22, 2023 15:31
@almeidx almeidx force-pushed the discord.js/avatar-decoration-presets branch from 1e1c732 to a4417d7 Compare November 2, 2023 01:40
@Jiralite
Copy link
Member

In discord.js, should this be checked for in equals()?

@almeidx almeidx marked this pull request as draft March 11, 2024 22:01
@Jiralite Jiralite linked an issue Apr 2, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Review Approved
Development

Successfully merging this pull request may close these issues.

User#avatarDecoration property is always null.
7 participants