Skip to content
This repository has been archived by the owner on Jan 8, 2022. It is now read-only.

feat(Rest): add response and request events #85

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

ckohen
Copy link
Member

@ckohen ckohen commented Dec 2, 2021

Please describe the changes this PR makes and why it should be merged:

Ported from discordjs/discord.js#6739

Needs #77

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@ckohen ckohen changed the title Response request events feat(Rest): add response and request events Dec 2, 2021
Ported from discordjs/discord.js#6739

Co-authored-by: Shubham Parihar <shubhamparihar391@gmail.com>
Co-authored-by: Rodry <38259440+ImRodry@users.noreply.github.com>
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
Co-authored-by: SpaceEEC <24881032+SpaceEEC@users.noreply.github.com>
@ckohen ckohen marked this pull request as ready for review December 2, 2021 23:04
@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #85 (7767eba) into main (c22081d) will increase coverage by 0.02%.
The diff coverage is 87.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   89.03%   89.06%   +0.02%     
==========================================
  Files           9        9              
  Lines        1487     1555      +68     
  Branches      153      160       +7     
==========================================
+ Hits         1324     1385      +61     
  Misses         12       12              
- Partials      151      158       +7     
Impacted Files Coverage Δ
packages/rest/src/lib/RequestManager.ts 93.96% <50.00%> (ø)
...ackages/rest/src/lib/handlers/SequentialHandler.ts 82.80% <85.71%> (+0.36%) ⬆️
packages/rest/src/lib/REST.ts 95.57% <89.74%> (-0.98%) ⬇️
packages/rest/src/lib/utils/constants.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c22081d...7767eba. Read the comment docs.

@iCrawl iCrawl added this to In progress in REST via automation Dec 6, 2021
REST automation moved this from In progress to Reviewer approved Dec 6, 2021
@iCrawl iCrawl merged commit c3aba56 into discordjs:main Dec 8, 2021
REST automation moved this from Reviewer approved to Done Dec 8, 2021
@ckohen ckohen deleted the response-request-events branch December 9, 2021 08:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
REST
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants