Skip to content
This repository has been archived by the owner on Jan 8, 2022. It is now read-only.

fix(CDN#icon): remove guild prefixes #67

Merged
merged 1 commit into from
Oct 18, 2021
Merged

fix(CDN#icon): remove guild prefixes #67

merged 1 commit into from
Oct 18, 2021

Conversation

vaporoxx
Copy link
Contributor

@vaporoxx vaporoxx commented Oct 6, 2021

Please describe the changes this PR makes and why it should be merged:

Cleans up some rebase oopsies from #53

Status and versioning classification:

  • I know how to update typings and have done so

@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #67 (7221121) into main (65cb8e2) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #67   +/-   ##
=======================================
  Coverage   85.84%   85.84%           
=======================================
  Files           8        8           
  Lines        1010     1010           
  Branches      101      101           
=======================================
  Hits          867      867           
  Misses         42       42           
  Partials      101      101           
Impacted Files Coverage Δ
packages/rest/src/lib/CDN.ts 86.74% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65cb8e2...7221121. Read the comment docs.

Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why Coverage dropped without changes but... LGTM!

@iCrawl iCrawl added this to In progress in REST via automation Oct 18, 2021
@iCrawl iCrawl merged commit 8882686 into discordjs:main Oct 18, 2021
REST automation moved this from In progress to Done Oct 18, 2021
@vaporoxx vaporoxx deleted the fix-icon branch October 18, 2021 15:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
REST
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants