Skip to content
This repository has been archived by the owner on Jan 8, 2022. It is now read-only.

feat(Rest): use native Node.js AbortController #66

Merged
merged 1 commit into from
Oct 18, 2021
Merged

feat(Rest): use native Node.js AbortController #66

merged 1 commit into from
Oct 18, 2021

Conversation

J-Human
Copy link
Contributor

@J-Human J-Human commented Oct 3, 2021

Please describe the changes this PR makes and why it should be merged:
Node.js already has an AbortController implementation, hence a poly fill is no longer needed.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@codecov
Copy link

codecov bot commented Oct 3, 2021

Codecov Report

Merging #66 (4298ada) into main (65cb8e2) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
- Coverage   85.84%   85.82%   -0.02%     
==========================================
  Files           8        8              
  Lines        1010     1009       -1     
  Branches      101      101              
==========================================
- Hits          867      866       -1     
  Misses         42       42              
  Partials      101      101              
Impacted Files Coverage Δ
...ackages/rest/src/lib/handlers/SequentialHandler.ts 83.02% <ø> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65cb8e2...4298ada. Read the comment docs.

@iCrawl iCrawl added the rest label Oct 18, 2021
@iCrawl iCrawl added this to In progress in REST via automation Oct 18, 2021
REST automation moved this from In progress to Reviewer approved Oct 18, 2021
@iCrawl iCrawl added dependencies Pull requests that update a dependency file and removed refactor rest labels Oct 18, 2021
@iCrawl iCrawl merged commit 3b53910 into discordjs:main Oct 18, 2021
REST automation moved this from Reviewer approved to Done Oct 18, 2021
@J-Human J-Human deleted the feat/use-native-abortcontroller branch October 18, 2021 23:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file
Projects
REST
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants