Skip to content
This repository has been archived by the owner on Jan 8, 2022. It is now read-only.

feat(CDN): add role icon endpoint #64

Merged
merged 2 commits into from
Oct 2, 2021
Merged

Conversation

iShibi
Copy link
Contributor

@iShibi iShibi commented Sep 22, 2021

Please describe the changes this PR makes and why it should be merged:

Adds roleIcon method to generate URL for a role's icon

Status and versioning classification:

  • I know how to update typings and have done so
  • This PR changes the library's interface (methods or parameters added)

@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #64 (fdb3f6b) into main (c4b2803) will increase coverage by 0.04%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   85.80%   85.84%   +0.04%     
==========================================
  Files           8        8              
  Lines        1000     1010      +10     
  Branches      100      101       +1     
==========================================
+ Hits          858      867       +9     
  Misses         42       42              
- Partials      100      101       +1     
Impacted Files Coverage Δ
packages/rest/src/lib/CDN.ts 86.74% <90.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4b2803...fdb3f6b. Read the comment docs.

kyranet
kyranet previously approved these changes Sep 28, 2021
packages/rest/src/lib/CDN.ts Outdated Show resolved Hide resolved
packages/rest/src/lib/CDN.ts Outdated Show resolved Hide resolved
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
@iCrawl iCrawl added this to In progress in REST via automation Oct 2, 2021
REST automation moved this from In progress to Reviewer approved Oct 2, 2021
@iCrawl iCrawl merged commit 4d7d692 into discordjs:main Oct 2, 2021
REST automation moved this from Reviewer approved to Done Oct 2, 2021
@iShibi iShibi deleted the role-icon-cdn branch October 6, 2021 13:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
REST
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants