This repository has been archived by the owner on Jan 8, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 30
feat(CDN#guildIcon): implement dynamic logic #53
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #53 +/- ##
==========================================
- Coverage 85.84% 85.80% -0.05%
==========================================
Files 8 8
Lines 996 1000 +4
Branches 99 100 +1
==========================================
+ Hits 855 858 +3
Misses 42 42
- Partials 99 100 +1
Continue to review full report at Codecov.
|
vladfrangu
previously approved these changes
Aug 21, 2021
iCrawl
previously approved these changes
Aug 21, 2021
kyranet
previously approved these changes
Aug 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to comment about me not liking this mutating pattern, but seems it's used in other methods, so I'll do a PR after this one to refactor that.
This needs a rebase @Fyko |
iCrawl
approved these changes
Sep 3, 2021
vladfrangu
approved these changes
Sep 3, 2021
kyranet
approved these changes
Sep 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Status and versioning classification: