Skip to content
This repository has been archived by the owner on Jan 8, 2022. It is now read-only.

feat(CDN#guildIcon): implement dynamic logic #53

Merged
merged 7 commits into from
Sep 7, 2021
Merged

feat(CDN#guildIcon): implement dynamic logic #53

merged 7 commits into from
Sep 7, 2021

Conversation

Fyko
Copy link
Contributor

@Fyko Fyko commented Aug 13, 2021

Please describe the changes this PR makes and why it should be merged:

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #53 (21bea12) into main (ceaab7d) will decrease coverage by 0.04%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   85.84%   85.80%   -0.05%     
==========================================
  Files           8        8              
  Lines         996     1000       +4     
  Branches       99      100       +1     
==========================================
+ Hits          855      858       +3     
  Misses         42       42              
- Partials       99      100       +1     
Impacted Files Coverage Δ
packages/rest/src/lib/CDN.ts 86.53% <66.66%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ceaab7d...21bea12. Read the comment docs.

@iCrawl iCrawl added this to In progress in REST via automation Aug 21, 2021
vladfrangu
vladfrangu previously approved these changes Aug 21, 2021
REST automation moved this from In progress to Reviewer approved Aug 21, 2021
iCrawl
iCrawl previously approved these changes Aug 21, 2021
kyranet
kyranet previously approved these changes Aug 22, 2021
Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to comment about me not liking this mutating pattern, but seems it's used in other methods, so I'll do a PR after this one to refactor that.

@iCrawl
Copy link
Member

iCrawl commented Aug 24, 2021

This needs a rebase @Fyko

@Fyko Fyko dismissed stale reviews from kyranet, iCrawl, and vladfrangu via 5356302 August 26, 2021 21:59
REST automation moved this from Reviewer approved to Review in progress Aug 26, 2021
REST automation moved this from Review in progress to Reviewer approved Sep 3, 2021
@iCrawl iCrawl merged commit c4b2803 into discordjs:main Sep 7, 2021
REST automation moved this from Reviewer approved to Done Sep 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
REST
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants