Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup chat input options #274

Merged
merged 5 commits into from
Dec 24, 2021
Merged

chore: cleanup chat input options #274

merged 5 commits into from
Dec 24, 2021

Conversation

vladfrangu
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

Internally, this is cleaner
Externally, this breaks EVERYTHING. I'm sorry in advance that you'll have to update your imports :(

Reference Discord API Docs PRs or commits:

Copy link
Member

@suneettipirneni suneettipirneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks go to me, tests seem to pass. Just one small nit

Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides Suneet's remark, this looks fine to me, pretty clean code.

@vladfrangu vladfrangu merged commit 7fe78ce into main Dec 24, 2021
@vladfrangu vladfrangu deleted the chore/cleanup-options branch December 24, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants