fix(NonDispatchPayload): t & s fields are always null on non-dispatch payloads
#259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpaceEEC
approved these changes
Dec 8, 2021
kyranet
reviewed
Dec 8, 2021
|
I just checked and this happens in all available gateway versions (6, 7, 8 and 9), so I will be adding these changes to the v8 and v6 files as well. Running the Deno script wasn't mentioned anywhere, so I wasn't aware that I had to run it but I will be also doing that as well. |
|
V6 is not getting updates anymore As for the deno script, if you installed node deps it should've automatically do it |
Ah, my bad. I did install the node deps but made my commit using a GUI client which seems to have bypassed the pre-commit hook, so the deno script was not executed. |
added 2 commits
December 8, 2021 11:46
kyranet
approved these changes
Dec 8, 2021
vladfrangu
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR does pretty much does the same thing as #258, except in a more elegant way. #258 would have made the field
tandsalways nullable, not just on non-dispatch payloads like this PR now does.Reference Discord API Docs PRs or commits:
https://github.com/discord/discord-api-docs/blob/master/docs/topics/Gateway.md?plain=1#L28-L31