Node 12 support and dependency/version updates #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR also makes #20 obsolete. The reason I chose to use abals changes is because I found them a lot cleaner and also made some improvements on using NAN more. |
TheAkio
force-pushed
the
master
branch
2 times, most recently
from
8095cb3
to
b71fe48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Node 12 (tested with 12.13.0). The functionality of this package was also tested for Node 8 (8.16.2) and Node 10 (10.16.3).
Thanks to @abalabahaha for his changes regarding the Node 12 support.
The version of the NPM package was updated to 0.1.3 The reason is that the package published on NPM is currently on 0.1.2 and the last publish was 3 years ago. I plan on publishing a new version onto there and this time I would like to do it without a separate repository that introduces changes not existing in here.