If encoding is set on ErlangTermDecoder, decode BINARY_EXT
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fozzle
force-pushed
the
bugfix/encoding-for-binary
branch
from
15e9cee
to
bf992ee
Compare
jhgg
reviewed
Oct 1, 2019
py/erlpack/_unpacker.pyx
Outdated
| try: | ||
| rv = rv.decode(self.encoding) | ||
| except UnicodeError: | ||
| pass |
There was a problem hiding this comment.
There’s merit in throwing here rather than silently failing.
There was a problem hiding this comment.
sure! wdyt about throwing in the STRING_EXT handler as well? It's not clear to me why that would silently continue while this would throw if the decoder is set to an encoding
jhgg
approved these changes
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I need to commit the🙃.cppfile to I just need to figure out how to build it correctly