This repository has been archived by the owner on Aug 28, 2020. It is now read-only.
Changed RichDisplayRunOptions.time docs
#715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes `RichDisplayRunOptions#time` documentation info, adding `in milliseconds` to the info. This little left-out detail has given me so much headache with debugging.
kyranet
added
Meta: Documentation
|
Does this need to go to CHANGELOG.md? |
|
That would probably cause merge conflicts since this PR doesn't target the alpha branch, but we do that. Thoughts @bdistin? |
|
Should we just retarget this to alpha branch? I didn't see that there's an alpha branch before submitting this PR. My bad. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the PR
This PR changes
RichDisplayRunOptions.timedocumentation info, addingin millisecondsto the info.Changes Proposed in this Pull Request (List new items in CHANGELOG.MD)
RichDisplayRunOptions.timedocumentation info to display the unit of time used.Semver Classification