Skip to content
This repository has been archived by the owner on Aug 28, 2020. It is now read-only.

typings: Make Task#run's data field be optional #714

Merged
merged 1 commit into from Jun 20, 2019
Merged

typings: Make Task#run's data field be optional #714

merged 1 commit into from Jun 20, 2019

Conversation

Skillz4Killz
Copy link
Contributor

Description of the PR

This PR allows using Tasks with no arguments. The typings currently have it set as required.

Changes Proposed in this Pull Request (List new items in CHANGELOG.MD)

  • Make Task.run() optional to pass in a argument

Semver Classification

  • This PR only includes documentation or non-code changes.
  • This PR fixes a bug and does not change the (intended) framework interface.
  • This PR adds methods or properties to the framework interface.
  • This PR removes or renames methods or properties in the framework interface.

@kyranet kyranet added Meta: Typings Issues and PRs related to typings. SEM: N/A PRs that only contain documentation changes and do not change the framework's interface. labels Jun 4, 2019
@vladfrangu vladfrangu changed the title Update index.d.ts typings: Make Task#run's data field be optional Jun 8, 2019
@bdistin bdistin merged commit 52d5427 into dirigeants:master Jun 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@stijnvdkolk stijnvdkolk stijnvdkolk approved these changes

Assignees
No one assigned
Labels
Meta: Typings Issues and PRs related to typings. SEM: N/A PRs that only contain documentation changes and do not change the framework's interface.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Skillz4Killz @vladfrangu @stijnvdkolk @bdistin @kyranet