Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FractionField allow arbitrary ground rings (e.g. not an integral domain) #1286

Open
skirpichev opened this issue Jan 21, 2023 · 1 comment
Open

FractionField allow arbitrary ground rings (e.g. not an integral domain) #1286

skirpichev opened this issue Jan 21, 2023 · 1 comment
Labels
domains polys wrong answer if mathematically wrong result was obtained
Milestone
1.0

Comments

@skirpichev
Copy link
Collaborator

That doesn't make sense, e.g.:

In [20]: Z4 = ZZ.finite_ring(4)

In [21]: R4 = Z4.poly_ring(x)

In [22]: X, = R4.gens

In [23]: 2*X
Out[23]: 2*x

In [24]: (2*X)*(2*X)  # Also _strip_zero should be called here.
Out[24]: 0*x**2
@skirpichev skirpichev added wrong answer if mathematically wrong result was obtained polys domains labels Jan 21, 2023
@skirpichev skirpichev added this to the 1.0 milestone Jan 21, 2023
@skirpichev
Copy link
Collaborator Author

Actually, probably we can unify FractionField and RationalField (as fields of fractions for different rings).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domains polys wrong answer if mathematically wrong result was obtained
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@skirpichev