New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix `ContiguousArena::remove` #37

Open

SludgePhD wants to merge 1 commit into dimforge:master from SludgePhD:fix-arena-remove

Contributor

SludgePhD commented Sep 19, 2022

Closes #33
Closes #31

Also adds a test

Contributor Author

SludgePhD commented Sep 24, 2022

Hmm, it's still broken with 3+ entries


          Fix ContiguousArena::remove

e5d9f8c

SludgePhD force-pushed the fix-arena-remove branch from ab340f5 to e5d9f8c Compare

September 24, 2022 19:01

Contributor Author

SludgePhD commented Sep 24, 2022

There we go. The fixup should only happen when an index was removed that is not at the end of the array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment