Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash with attempt to subtract with overflow in SAPRegion::update_after_subregion_removal() #593

Open
ppykalo opened this issue Feb 20, 2024 · 1 comment

Comments

@ppykalo
Copy link

ppykalo commented Feb 20, 2024

I am using rapier 0.18.0 through bevy_rapier2d 0.24.0 and noticed occasional attempt to subtract with overflow in update_after_subregion_removal() on subtract from self.subproper_proxy_count. I cloned rapier repo, added some debug and turns out that axis.delete_deleted_proxies_and_endpoints_after_subregion_removal() call returns 1 but self.subproper_proxy_count equals 0 so subtraction causes panic in debug build.

As quick workaround I changed the subtraction to self.subproper_proxy_count = self.subproper_proxy_count.saturating_sub(num_deleted_proxies) but it's out of my rapier knowledge to fix this properly.

I'm attaching log containing debug outputs and stack backtrace + diff with changes I made. I know how to reproduce this problem (~50% chance) with current state of my project so it's possible to provide additional logs if needed.
log.txt
diff.txt

@feroldi
Copy link

feroldi commented Mar 22, 2024

I'm having this exact problem as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants