Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS: make sure all the functions taking callbacks are not registering an event listener. #82

Open
sebcrozet opened this issue Jan 18, 2024 · 0 comments
Open

JS: make sure all the functions taking callbacks are not registering an event listener. #82

sebcrozet opened this issue Jan 18, 2024 · 0 comments
Labels
M-JS about javascript integration P-Medium Medium Priority S-not-started Work has not started on it

Comments

@sebcrozet
Copy link
Member

sebcrozet commented Jan 18, 2024 •
edited

This has been a common misconception where, an JS, event listener are a quite common pattern. But, in Rapier, these function (drainCollisionEvents,intersectionsWith, etc.) only gets called once as they don’t register any persistent "event handler".
See https://discord.com/channels/507548572338880513/748814906953826334/1197087923053535272
@Vrixyz Vrixyz added S-not-started Work has not started on it P-Medium Medium Priority M-JS about javascript integration labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
M-JS about javascript integration P-Medium Medium Priority S-not-started Work has not started on it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sebcrozet @Vrixyz