Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup hangs indefinitely after a successful build of rapier-compat #43

Open
sebcrozet opened this issue Aug 31, 2021 · 3 comments
Open
Labels
bug Something isn't working

Comments

@sebcrozet
Copy link
Member

For some reasons, Rollup hangs indefinitely after a successful build of rapier-compat (cd compat; npm run build;).
This makes the release process annoying as I have to manually kill the task. And this prevents the CI from terminating.

@LeXXik
Copy link

LeXXik commented Aug 31, 2021

Hmm, trying to compile Wasm for 0.7.2 (non-compat) and it gives me compilation errors. If the compat version compiles it and embeds as string, maybe this could be related.

image

On screenshot I am trying to first instantiateStreaming(), which fails and falls back to compile(), which fails too.

@sebcrozet
Copy link
Member Author

It looks like the hang is caused by rollup/rollup#4213 which is itself caused by a bug in TypeScript. The TypeScript bug has been merged: microsoft/TypeScript#45642 but not released yet. So we either need to wait for a new TypeScript release, or we need to downgrade it to an older version (TypeScript 4.3.5 appears to work).

@jcyuan
Copy link
Contributor

jcyuan commented Jan 7, 2022

https://github.com/wasm-tool/rollup-plugin-rust

use this plugin directly, you can even just import from Cargo.toml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants