Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wish] Make sort2 and sort3 public #135

Open
wlinna opened this issue Mar 25, 2023 · 0 comments
Open

[wish] Make sort2 and sort3 public #135

wlinna opened this issue Mar 25, 2023 · 0 comments

Comments

@wlinna
Copy link
Contributor

wlinna commented Mar 25, 2023

Is there a reason to limit the visibility of sort2 and sort3 to pub(crate)? If not, I propose that the visibility would be changed to pub.

In my case they'd be useful for reimplementing some of the functions in parry. I use f32 version of parry, but occasionally need higher precision. In those cases I copy the original implementation and change f32 to f64. Not having these utility functions available means that I have to copy them too, and change the references.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant