Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves several issues encountered when trying to build with the alloc feature.
For one, the alloc feature is stable, and has been since Rust 1.36.0:
Secondly, this breaks the build on stable:
It also fails to build on nightly with the feature configuration we have in Rust CV:
All of these issues are solved by this PR.
We may also want to add a follow up to test
alloc
feature on stable in CI. Currently, the tests aren't even ran, and it only builds with nightly.