Add a OPoint type that takes type-level integers instead of const-generics #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And define Point<T, const D: usize> as an alias for OPoint.
point_dim_name: Fix serde impls and Distribution impl for OPoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs change the
Pointtype so that its underlying implementation is based on type-level integers instead of const-generics. This introducesOPointwhich takes type-level integers for its dimension, andPointis now a type-alias that takes const-generics for its dimension.This changes is effectively a partial rollback of our migration to const-generics. This was requires because only allowing const-generics for point dimensions would code severe breakage on generic code using points. (And these breakage were unfixable because of the current limitations of const-generics.)