Make display generical for Omatrix #938
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous version, the test added in tests/core/matrix.rs failed to compile.
This version remove the dependency to the
Allocator<usize>
, so that the display implementation does not depend of the allocator ofnalgebra
, making it generical forOMatrix
.Not relying on
Omatrix<usize, R, C>
implies that some computation have to be done twice.However, the performance hit is only in
Display
, which I find acceptable (the use case will be for debugging/writing logs)The difference with the previous version is that
val_width
is called twice per entry instead of once.