Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple version of the optional glam conversion #900

Merged
merged 2 commits into from Jun 1, 2021

Conversation

sebcrozet
Copy link
Member

This removes the convert-glam and convert-glam-unchecked features.
Instead, this adds the convert-glam013, convert-glam014, and convert-glam015 features for conversions targeting the versions 0.13, 0.14, and 0.15 of glam.

With this change of features naming, we can provide conversions for multiple versions of glam, and a major version bump for glam will no longer require a major version bump for nalgebra.

The conversions behind the convert-glam-unchecked feature have been replaced by TryFrom impls or conversions that transform the input to generate a valid output.

@sebcrozet sebcrozet added enhancement breaking change Fixing this issue, or merging this pull-request is likely to require breaking changes labels Jun 1, 2021
@sebcrozet sebcrozet merged commit de705a8 into dev Jun 1, 2021
@sebcrozet sebcrozet deleted the glam-multiversion branch June 1, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Fixing this issue, or merging this pull-request is likely to require breaking changes enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant