Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Quaternion logarithm inconsistent with exp #1363

Open
molni opened this issue Feb 26, 2024 · 1 comment
Open

Unit Quaternion logarithm inconsistent with exp #1363

molni opened this issue Feb 26, 2024 · 1 comment

Comments

@molni
Copy link

molni commented Feb 26, 2024

Unit<Quaternion>::ln and Quaternion::ln differ, which is unexpected. Quaternion::ln seems to be correct and it is consistent with Quaternion::exp, at least on data I encountered.

[dependencies]
nalgebra = "0.32.3"
    #[test]
    fn quaternion_2() {
        let p = UnitQuaternion::from_scaled_axis(Vector3::new(1., 2., 3.));
        let q = p.into_inner();
        assert!((q.ln().exp() - q).norm() < 1e-9); // OK - Quaternion<f64>::ln
        assert!((p.ln().exp() - q).norm() < 1e-9); // fails - Unit<Quaternion<f64>>::ln
    }
@molni
Copy link
Author

molni commented Feb 26, 2024

After investigating more:

    #[test]
    fn quaternion_3() {
        let p = UnitQuaternion::from_scaled_axis(Vector3::new(0., 0., 1.));
        let q = p.into_inner();
        dbg!(q.ln());
        dbg!(p.ln());
        assert!((q.ln().exp() - q).norm() < 1e-9); // OK - Quaternion<f64>
        assert!((p.ln().exp() - q).norm() < 1e-9); // fails - Unit<Quaternion<f64>>
    }

outputs

[src/main.rs:559:9] q.ln() = [
    0.0,
    0.0,
    0.4999999999999999,
    0.0,
]
[src/main.rs:560:9] p.ln() = [
    0.0,
    0.0,
    1.0,
    0.0,
]

Seems like UnitQuaternion implemetation expects ln to return scaled_axis instead of returning half of it, contrary to correct statement in the doccomment of the function itself (UnitQuaternion::ln): "The vector part of the return value corresponds to the axis-angle representation (divided by 2.0) of this unit quaternion".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant