digitalocean_record ttl seems not to be idempotent

[niklasweimann]

Bug Report

Describe the bug

When there are two TXT for a single Domain with different TTLs the TTL for the individual records is not preserved instead it seems to pick the TTL of the record which is handled first. So with each run the TTL is toggled.

Affected Resource(s)

• digitalocean_record

Expected Behavior

When the TTL of one record is set to 60 and the TTL of another record to 1800, i want the records to keep the TTL after applying.

Actual Behavior

One record looses its TTL and both records get the same TTL assigned.

Steps to Reproduce

1. Create two record ressources like so:

resource "digitalocean_record" "test_txt_1" {
  domain   = digitalocean_domain.example_com.name
  type     = "TXT"
  name     = "@"
  value    = "1"
  ttl      = 60
}

resource "digitalocean_record" "test_txt_2" {
  domain   = digitalocean_domain.example_com.name
  type     = "TXT"
  name     = "@"
  value    = "2"
  ttl      = 1800
}

2. Apply the Terraform

3. Go to the Web UI and find the following records:

   1. 

4. Rerun the Plan and Apply the plan looks like this:

   1. 

5. Go to the Web UI and find the following records:

   1. 

Terraform version
1.5.3

[danaelhe]

Hi @niklasweimann ,

Thank you for your detailed write up. This is actually expected behavior of our API as it follows the "Clarifications to the DNS Specification" RFC recommendations. Per the RFC, when you have multiple records for the same fqdn, they are expected to have the same TTL. For reference, see rfc2181, section 5.2: https://www.rfc-editor.org/rfc/rfc2181#section-5.

[danaelhe]

I'm going to close this. Please create another issue if you have any other concerns/questions, thank you so much!

[DanRStevens]

It seems like mismatched TTLs in Resource Record Sets should produce some kind of warning. It's very confusing behaviour otherwise. If the code is able to set all records to the same TTL, surely it should be easy to add a warning in that case, and perhaps even list the affected records.

[danaelhe]

multiple records for the same fqdn, they are expected to have the same TTL

I like it! Thanks for offering this feedback, I've created PR #1157 implementing your suggestion 🚀

[DanRStevens]

Wow, that was fast. Thanks