Add support for Reserved IP addresses #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Floating IPs are being renamed to Reserved IPs. We'll need to support both for awhile, treating them as distinct resource types until Floating IPs are deprecated or removed. This change allows the caller to use either or both at the same time. Signed-off-by: Chris Cummer <chriscummer@me.com>
This was referenced May 23, 2022
Merged
Signed-off-by: Chris Cummer <chriscummer@me.com>
senorprogrammer
commented
Jun 15, 2022
| "next":"http://example.com/v2/floating_ips/?page=3", | ||
| "prev":"http://example.com/v2/floating_ips/?page=1", | ||
| "last":"http://example.com/v2/floating_ips/?page=3", | ||
| "first":"http://example.com/v2/floating_ips/?page=1" | ||
| } |
There was a problem hiding this comment.
This is a pedantic change that has no functional impact. The routes in the returned JSON were incorrect for the resource type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Floating IPs are being renamed to Reserved IPs. We'll need to
support both for awhile, treating them as distinct resource
types until Floating IPs are deprecated or removed.
This change allows the caller to use either or both at the same
time.
Signed-off-by: Chris Cummer chriscummer@me.com