Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes - use bool pointers to parse requests correctly #548

Closed
wants to merge 1 commit into from
Closed

kubernetes - use bool pointers to parse requests correctly #548

wants to merge 1 commit into from

Conversation

varshavaradarajan
Copy link
Contributor

Fixes #524

adamwg
adamwg reviewed Aug 15, 2022
View reviewed changes
Copy link
Contributor

@adamwg adamwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change lgtm, but would break backward compatibility. We should discuss with @andrewsomething and team how to manage that.

andrewsomething
andrewsomething requested changes Aug 24, 2022
View reviewed changes
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We talked about this elsewhere, but wanted to make the status clear here. Unfortunately this is a breaking change that would break customers' builds. One way we might do this in a non-breaking manner might be:

https://go.dev/play/p/9ahfIpkhH3o

@ChiefMateStarbuck
Copy link
Member

closing due to staleness

@ChiefMateStarbuck
Copy link
Member

Closing due to planned internal fix. More communication to come soon for customers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwg adamwg adamwg left review comments

@andrewsomething andrewsomething andrewsomething requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kubernetes surge_upgrade field cannot be set to false
4 participants
@varshavaradarajan @ChiefMateStarbuck @andrewsomething @adamwg