You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
AFAIK the first two use the raw bytes of the attributes while the second uses the string contents of type and value of the attributes
This causes certificates that are directly generated by code and added to a CA to have a different hash than the same certificate after a pem encode/decode operation
https://github.com/digitalbazaar/forge/blob/main/lib/x509.js#L1377 and https://github.com/digitalbazaar/forge/blob/main/lib/x509.js#L1393
vs
https://github.com/digitalbazaar/forge/blob/main/lib/x509.js#L2824
AFAIK the first two use the raw bytes of the attributes while the second uses the string contents of
type
andvalue
of the attributesThis causes certificates that are directly generated by code and added to a CA to have a different hash than the same certificate after a pem encode/decode operation
Not sure which hash is the correct one
Here are two commits, one adding a failing test and the other fixing the test (but failing the existing hash calculation test) https://github.com/simhnna/forge/tree/failing-test
The text was updated successfully, but these errors were encountered: