Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle (other) users that exist in Alma but don't in LDAP #29

Open
3 tasks
lazka opened this issue Apr 18, 2023 · 0 comments
Open
3 tasks

Handle (other) users that exist in Alma but don't in LDAP #29

lazka opened this issue Apr 18, 2023 · 0 comments

Comments

@lazka
Copy link
Member

lazka commented Apr 18, 2023

In case there exist users in Alma that doesn't in LDAP (because the user got removed) we should communicate that to the frontend and don't fail for operations where they are optional:

Assume there is a user NONEXIST that is missing in LDAP:

  • Borrow book: If NONEXIST has already borrowed it we shouldn't fail with an alma-id error, instead with "Existing loan was found!".

  • Return book: If it gets returned for NONEXIST then maybe we can ignore the error? And just show "Borrower: Unknown"

  • Show current loan list: Show the loans by NONEXIST with "Unknown" instead of the email button.

In case we return a "Person" from the API things get tricky. Not sure what to do there.. maybe just return null and let the frontend handle it..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant