Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: maven plugin should identify skip config key #1353

Merged
merged 2 commits into from Sep 28, 2022

Conversation

tisonkun
Copy link
Contributor

CHANGES updates will be pushed later. I trigger the CI tasks first.

Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Copy link
Contributor Author

Confirm this patch works locally.

@bbarker-eb you can help with testing this patch by building a local snapshot follow these instructions.

@jherico I don't know the issue about "ratchetFrom" or something. You can test that this patch doesn't cause regression.

@nedtwigg please help with reviewing. I hope this patch is a trivial fix to merge.

Updating CHANGES file now...

Signed-off-by: tison <wander4096@gmail.com>
@nedtwigg
Copy link
Member

Thanks a lot @tisonkun! I'm ready to merge and release as soon as I get one "works for me" from someone.

@imaffe
Copy link

imaffe commented Sep 28, 2022

I'm trying to walk through the reproduce process.

@EricGao888
Copy link
Contributor

EricGao888 commented Sep 28, 2022

Thanks a lot @tisonkun! I'm ready to merge and release as soon as I get one "works for me" from someone.

@nedtwigg I have pulled this PR and tested the patch built from it locally. It works for me.

Some detailed related to my local test:

2.27.0 - not worked
image

2.27.1-SNAPSHOT built from this PR - worked well
image

@syhily
Copy link

syhily commented Sep 28, 2022

This PR works for me on my local machine.

@imaffe
Copy link

imaffe commented Sep 28, 2022

image

Has spot failure and have skip enabled, but not skipped on 2.26
image

After changing to local build 2.27.1-SNAPSHOT
image

And skipped:
image

@nedtwigg nedtwigg merged commit 50e0186 into diffplug:main Sep 28, 2022
@tisonkun tisonkun deleted the issue-1227 branch September 28, 2022 17:28
@nedtwigg
Copy link
Member

Thanks very much to @tisonkun for the fix and everyone else for the testing confirmation! Released in plugin-maven 2.27.1. Should be available now, but mavenCentral has had some sync slowness recently, it'll get there within a few hours if it's not there already.

@bbarker-eb
Copy link

bbarker-eb commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maven plugin skip no longer functional in 2.19.0 and above Maven plugin should support skip
6 participants