Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maven plugin skip no longer functional in 2.19.0 and above #1227

Closed
bbarker-eb opened this issue Jun 2, 2022 · 5 comments · Fixed by #1353
Closed

Maven plugin skip no longer functional in 2.19.0 and above #1227

bbarker-eb opened this issue Jun 2, 2022 · 5 comments · Fixed by #1353
Assignees
@lutovich
Labels
bug-unconfirmed

Comments

@bbarker-eb
Copy link

bbarker-eb commented Jun 2, 2022 •
edited

The issue/enhancement: Maven plugin should support skip #491 no longer functions as of release 2.19.0.
mvn spotless:check or mvn spotless:apply does not get skipped as in earlier releases.
<plugin> <groupId>com.diffplug.spotless</groupId> <artifactId>spotless-maven-plugin</artifactId> <version>2.19.0</version> <configuration> <skip>true</skip> </configuration> </plugin>
@bbarker-eb bbarker-eb changed the title Maven plugin skip no longer functional Maven plugin skip no longer functional in 2.19.0 and above Jun 2, 2022
@tisonkun tisonkun mentioned this issue Sep 28, 2022
Merged
@tisonkun
Copy link
Contributor

Ditto here apache/flink#20911. I'm working on a fix.

@tisonkun
Copy link
Contributor

tisonkun commented Sep 28, 2022 •
edited

It seems this commit changes the manner: d83eee2

@tisonkun
Copy link
Contributor

OK. I locate the root cause and can show you a workaround at apache/flink#20911 while prepare a patch to keep the manner.

@tisonkun
Copy link
Contributor

Root cause: 6788e17

@tisonkun tisonkun mentioned this issue Sep 28, 2022
Merged
nedtwigg added a commit that referenced this issue Sep 28, 2022
@nedtwigg
fix: maven plugin should identify skip config key (#1353 fixes #1227 …
50e0186 
…and #491)
@nedtwigg
Copy link
Member

Fixed by @tisonkun, available in plugin-maven 2.27.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lutovich lutovich

Labels
bug-unconfirmed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: maven plugin should identify skip config key tisonkun/spotless
4 participants
@lutovich @nedtwigg @tisonkun @bbarker-eb