Spotless 6.0.4 fails with Object.hashCode exception
#1024
Labels
Comments
|
I think this issue was introduced in 82c3435 |
Closed
6 tasks
|
Hmm, very strange. I can confirm on my machine that the mockito build with Spotless stacktraceThe null is from L71 of the little section below. It's passing null on a get() of this ConcurrentHashMap. Updating Gradle to Can you update Gradle to |
|
I suppose we can yes, but not sure when I can get to it. Do you mind opening a PR for it if you already have a local working version of it? |
I am a maintainer for Spotless, not every other project that uses Spotless :) I very much appreciate the reproducible test case, probably others will bump into this issue too, so this will be helpful to them too. Feel free to post back if more info becomes available, but I'm closing as "fixed by Gradle 7.3.1". |
TimvdLippe
added a commit
to mockito/mockito
that referenced
this issue
Dec 13, 2021
This release officially supports Java 17 and is supposedly fixing diffplug/spotless#1024
Ah apologies I thought you already had a local branch working with Gradle 7.3.1, so I was mostly curious if you could upload that. We are upgrading to version 7.3.1 in mockito/mockito#2509 and hopefully that unblocks mockito/mockito#2501 |
TimvdLippe
added a commit
to mockito/mockito
that referenced
this issue
Dec 13, 2021
This release officially supports Java 17 and is supposedly fixing diffplug/spotless#1024
This sounds a bit similar to #1087 but maybe it is only superficially related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Today, I received a Dependabot update for Spotless on Mockito: mockito/mockito#2501 The build failed (https://github.com/mockito/mockito/runs/4450375421?check_suite_focus=true) with the following exception:
Gradle version: 7.2
Spotless: 6.0.4 (works fine with 6.0.2)
Configuration:
spotless { // We run the check separately on CI, so don't run this by default enforceCheck = false java { licenseHeaderFile rootProject.file('config/spotless/spotless.header') custom 'google-java-format', { source -> com.google.googlejavaformat.java.JavaFormatterOptions options = new com.google.googlejavaformat.java.JavaFormatterOptions.Builder() .style(com.google.googlejavaformat.java.JavaFormatterOptions.Style.AOSP) .formatJavadoc(false) .build() com.google.googlejavaformat.java.Formatter formatter = new com.google.googlejavaformat.java.Formatter(options) return formatter.formatSource(source) } // This test contains emulation of same-line stubbings. The formatter would put them on a separate line. targetExclude 'src/test/java/org/mockitousage/internal/junit/UnusedStubbingsFinderTest.java' } }The text was updated successfully, but these errors were encountered: