Add all imported SASS files to the "watch" list #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* After every file render, grab all the includedFiles and add them all to the rollup watch list.
elycruz
reviewed
Jul 20, 2022
There was a problem hiding this comment.
@xenobytezero Hey, could you add missing semicolons (thanks) Nevermind @xenobytezero , I'll add them 👍🏽
|
Feature to be published by EOD 07/21. |
|
Awesome, thanks! |
|
Yeah, not a prob (👍🏽 ). |
elycruz
added a commit
that referenced
this pull request
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the missing features for this plugin was that any files imported by the target file were not watched by Rollup, and so it wasn't particularly useful when running Rollup in
--watchmode.This PR adds all of a files
includedFilesreturned after a render to the Rollup watch listthis.addWatchFile()