Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta] remove duplicate crate versions #1050

Open
1 of 66 tasks
metajack opened this issue Sep 24, 2019 · 8 comments
Open
1 of 66 tasks

[meta] remove duplicate crate versions #1050

metajack opened this issue Sep 24, 2019 · 8 comments
Labels
bug Something isn't working meta meta-issue

Comments

@metajack
Copy link
Contributor

metajack commented Sep 24, 2019

We currently have 49 duplicate crate versions in Libra Core. This meta bug documents them and tracks progress eliminating them.

To get a full list you can run cargo lockfile dups.

Duplicate Crate Versions

@metajack metajack added bug Something isn't working meta meta-issue labels Sep 24, 2019
@metajack
Copy link
Contributor Author

The old scopeguard seems to come in via yamux and tokio-reactor. Tokio issue is tokio-rs/tokio#1348. yamux needs a dependency update.

@metajack
Copy link
Contributor Author

sha2 0.7.1 comes via rusoto, which needs a dependency upgrade.

@metajack
Copy link
Contributor Author

rusoto/rusoto#1510 submitted upstream to fix sha2 dupe.

@huitseeker
Copy link
Contributor

One count of rand 0.4.x probably comes from crypto/crypto's import of zkcrypto/pairing, upstream issue zkcrypto/pairing#105

@huitseeker
Copy link
Contributor

The (curve|x|ed25519)-dalek disjunction comes from us: client uses the upstream repo, crypto uses this series of forks:
https://github.com/calibra/ed25519-dalek
https://github.com/calibra/x25519-dalek
https://github.com/calibra/curve25519-dalek
This is a temporary situation necessary to help us offer the option of a formalized crypto backend for those, work is ongoing to no longer need those forks in the first place.

@metajack
Copy link
Contributor Author

@huitseeker Thanks for those. I've updated the issue. Is there a tracking issue for unforking?

@metajack
Copy link
Contributor Author

Updated the list and removed all the fixed ones. 36 dupes now.

@metajack
Copy link
Contributor Author

Updated the list and removed fixed. 54 dupes now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working meta meta-issue
Projects
None yet
Development

No branches or pull requests

2 participants