added floating point limit support #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anopheles
commented
Jan 30, 2018
| func NewLimiter(max int64, tbOptions *limiter.ExpirableOptions) *limiter.Limiter { | ||
| return limiter.New(tbOptions).SetMax(max).SetBurst(int(max)) | ||
| func NewLimiter(max float64, tbOptions *limiter.ExpirableOptions) *limiter.Limiter { | ||
| return limiter.New(tbOptions).SetMax(max).SetBurst(int(math.Max(1, max))) |
There was a problem hiding this comment.
this had to be done to allow rates below 1, otherwise SetBurst(0) would always result in exceeded rate limits.
|
Thanks for the PR, I'll spend some time on the weekend to push a proper release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
here's my pull request, note that this is a breaking change, since the limiter now assumes a float64 instead of a int64 (a version bump might be inplace :))