Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting CI is broken #423

Closed
loostrum opened this issue Dec 1, 2022 · 5 comments · Fixed by #424
Closed

Linting CI is broken #423

loostrum opened this issue Dec 1, 2022 · 5 comments · Fixed by #424

Comments

@loostrum
Copy link
Member

loostrum commented Dec 1, 2022

See the following screenshot from https://github.com/dianna-ai/dianna/actions/runs/3593771040/jobs/6051161094:

image

@loostrum
Copy link
Member Author

loostrum commented Dec 2, 2022

We already install prospector[with_pyroma] exactly as suggested in the screenshot and it worked before. Perhaps an update to prospector/pyroma broke this

@egpbos
Copy link
Member

egpbos commented Dec 2, 2022

Highly likely. There was an update yesterday: https://pypi.org/project/prospector/#history Also an update three hours ago, so maybe it was fixed. But looking at the log of that run, I also see this:

Schermafbeelding 2022-12-02 om 16 22 23

Not sure if 1.8.2 fixes that...

@egpbos
Copy link
Member

egpbos commented Dec 2, 2022

Maybe just try installing pyroma explicitly? Or disable it in linting config, not sure what it does or whether it is even used here anyway (it gives a score, not a fail/pass, I think).

@loostrum
Copy link
Member Author

loostrum commented Dec 2, 2022

Ah good catch. There's already an open issue in the prospector repo: landscapeio/prospector#545
It can still fail even if pyroma is installed, so we could also just pin the prospector version to 1.8.0 for now

@loostrum
Copy link
Member Author

loostrum commented Dec 6, 2022

I'm also not sure what pyroma actually does. I opened a PR with the least-effort way of getting it to run again: pinning the version

egpbos added a commit that referenced this issue Jan 11, 2023
Version 1.8.4 should have fixed the issues previously mentioned in #423.
See https://github.com/PyCQA/prospector/milestone/7?closed=1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants