Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: remove the jna dependency #67

Closed
PiprTuff opened this issue Apr 27, 2022 · 1 comment
Closed

feature request: remove the jna dependency #67

PiprTuff opened this issue Apr 27, 2022 · 1 comment
Assignees

Comments

@PiprTuff
Copy link

The JNA dependency is now redundant. It should be removed.

@dialex dialex self-assigned this Apr 30, 2022
@dialex
Copy link
Owner

dialex commented Apr 30, 2022

For future reference, (as I keep returning to this issue and forget what's the current state), here's some context.

The JNA dependency was introduced because of this: Windows 10 users assumed JColor didn't work, but in fact it was a limitation of Windows. The JNA allowed us to change a Windows default without the user noticing, so that JColor works as expected.

Later on, I decided to stop doing that for the users, so that I could remove the JNA dependency and keep this library lean. So now Windows 10 users already have to fix this by themselves, and I made a detailed list of workarounds and instructions.

At this point, the only thing missing is removing the dependency, because the code that used that dependency was already removed. I'll create a PR to clean that up once and for all.

Thanks for reminding me about this 😉

@dialex dialex closed this as completed in 0fe7cf7 May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants