Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate inside knex official docs #286

Open
rluvaton opened this issue Apr 7, 2024 · 6 comments
Open

Integrate inside knex official docs #286

rluvaton opened this issue Apr 7, 2024 · 6 comments

Comments

@rluvaton
Copy link

rluvaton commented Apr 7, 2024 •
edited

Hey, Knex.js maintainer here, would you be interested of integrating this inside the official knex docs?
@dgadelha
Copy link
Owner

dgadelha commented Apr 8, 2024

For sure, that would be awesome!

@rluvaton
Copy link
Author

rluvaton commented Apr 8, 2024 •
edited

Our docs is currently in vue, it would be great if you can create a PR to add your code there as a separate tab (Next to guide tab)

My next idea is to have examples in the docs with autocomplete

@dgadelha
Copy link
Owner

dgadelha commented Apr 8, 2024

Alright, I'll attempt to

@rluvaton
Copy link
Author

Thank you!

@dgadelha
Copy link
Owner

@rluvaton can you take a look? knex/knex#6059

@rluvaton
Copy link
Author

Sure, missed that with all the notifications

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dgadelha @rluvaton