Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 16.4.2 and AmpHelpers.Action #27

Closed
harmony7 opened this issue Aug 3, 2018 · 3 comments
Closed

React 16.4.2 and AmpHelpers.Action #27

harmony7 opened this issue Aug 3, 2018 · 3 comments

Comments

@harmony7
Copy link

harmony7 commented Aug 3, 2018

ReactDOM 16.4.2 (released yesterday) made a change that sanitizes unknown attribute names and drops those attributes outright. So the workaround that AmpHelpers.Action uses does not work anymore.

Not sure how you'd work around this, just putting it out there. I reverted to ReactDOM 16.4.1 for now.

@harmony7 harmony7 changed the title React 16.4.2 React 16.4.2 and AmpHelpers.Action Aug 3, 2018
@antonybudianto
Copy link

Having this issue too, for now I use:

   <h1 data-amp-bind-text="heading.text">{defaultHeading.text}</h1>

@nahushf
Copy link

nahushf commented Dec 28, 2018

Was facing the same problem both in Action and Bind components. @antonybudianto's solution worked for me.

@dfrankland
Copy link
Owner

Should work starting with version 3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants