From a1f09a954bdbbfd70cf96c40476d3ad366644262 Mon Sep 17 00:00:00 2001 From: peterpeterparker Date: Wed, 31 Aug 2022 09:26:19 +0200 Subject: [PATCH 1/4] fix: return after resolve to avoid idb to be recreated --- packages/auth-client/src/storage.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/auth-client/src/storage.ts b/packages/auth-client/src/storage.ts index 8bbfed55c..17b6240f8 100644 --- a/packages/auth-client/src/storage.ts +++ b/packages/auth-client/src/storage.ts @@ -72,7 +72,10 @@ export class IdbStorage implements AuthClientStorage { private initializedDb: IdbKeyVal | undefined; get _db(): Promise { return new Promise(resolve => { - if (this.initializedDb) resolve(this.initializedDb); + if (this.initializedDb) { + resolve(this.initializedDb); + return; + } IdbKeyVal.create({ version: DB_VERSION }).then(db => { this.initializedDb = db; resolve(db); From e53192131d858cb49f56e269829f298d7136f13a Mon Sep 17 00:00:00 2001 From: peterpeterparker Date: Wed, 31 Aug 2022 09:30:37 +0200 Subject: [PATCH 2/4] docs: typo --- packages/auth-client/src/storage.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/auth-client/src/storage.ts b/packages/auth-client/src/storage.ts index 17b6240f8..b713241cc 100644 --- a/packages/auth-client/src/storage.ts +++ b/packages/auth-client/src/storage.ts @@ -68,7 +68,7 @@ export class LocalStorage implements AuthClientStorage { * @see implements {@link AuthClientStorage} */ export class IdbStorage implements AuthClientStorage { - // Intializes a KeyVal on first request + // Initializes a KeyVal on first request private initializedDb: IdbKeyVal | undefined; get _db(): Promise { return new Promise(resolve => { From e5ec26eb7c3a977b754e245dcaeb3ea97ffdcd2c Mon Sep 17 00:00:00 2001 From: peterpeterparker Date: Wed, 7 Sep 2022 07:38:08 +0200 Subject: [PATCH 3/4] docs: add changelog entry --- docs/generated/changelog.html | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/docs/generated/changelog.html b/docs/generated/changelog.html index 54c039535..3ceed773a 100644 --- a/docs/generated/changelog.html +++ b/docs/generated/changelog.html @@ -19,6 +19,13 @@

Version 1.0.0

using the abstract class PrincipalLike as the signature. It will be compatible across versions of agent-js. +
  • + bug: auth-client resolves window.open issue in login function in safari due to async + storage call +
  • +
  • + bug: auth-client storage wrapper returns after resolve to avoid idb to be recreated +
  • Version 0.13.2

    From cb611f60ddadf4e5a27164deab35f0712ffe67f6 Mon Sep 17 00:00:00 2001 From: Kyle Peacock Date: Tue, 20 Sep 2022 11:45:05 -0700 Subject: [PATCH 4/4] Update changelog.html --- docs/generated/changelog.html | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/docs/generated/changelog.html b/docs/generated/changelog.html index f021820ec..c50a75442 100644 --- a/docs/generated/changelog.html +++ b/docs/generated/changelog.html @@ -10,16 +10,6 @@

    Agent-JS Changelog

    -

    Version X.Y.Z

    -
      -
    • - bug: auth-client resolves window.open issue in login function in safari due to async - storage call -
    • -
    • - bug: auth-client storage wrapper returns after resolve to avoid idb to be recreated -
    • -

    Version 0.13.4

    • chore: auth-client expose storage constant keys