Let liveQuery() be type-wise compable with RxJS #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Observable returned from
liveQuery()is compatible with both RxJS and the current Ecmascript observable proposal. However, RxJS latest version requires the typing of it to have a [Symbol.observable] or else RxJS require the Observable to have all the Rx-specific old and deprecated properties on it.In order for make it not just runtime compatible with RxJS but also in its typings, we need to patch the global Symbol type with an observable property just as RxJS does in its typings (according to Ecmascript observable proposal. This global type patching does not conflict with neither RxJs or ES proposal as of current.