Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to specify id for patch action #128

Open
tomers opened this issue May 2, 2018 · 0 comments
Open

Need to specify id for patch action #128

tomers opened this issue May 2, 2018 · 0 comments

Comments

@tomers
Copy link
Collaborator

tomers commented May 2, 2018

In order to patch to work properly, one need to add the id field to the payload parameter of the patch command:

export const setScreenHomeAction = ({commit}, {screenId, isHome}) => {
  jsonApiInstance.one('screen', screenId).patch({id: screenId, home: isHome})
    .then((response) => {
      if (response.error === undefined && response.data.id === screenId && response.data.home === isHome) {
        commit('updateHome', {screenId: screenId, isHome: isHome})
      }
    })
    .catch((error) => {
      console.error(error)
    })
}

I think it is desired that the id is inferred from the id field pushed to the builderStack by the one directive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant