Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If using Warnings for SL messages, recommend providing WarningsNotAsErrors #76

Open
kzu opened this issue Sep 5, 2023 · 0 comments
Open
Labels
documentation Improvements or additions to documentation

Comments

@kzu
Copy link
Contributor

kzu commented Sep 5, 2023

From the feedback at https://github.com/moq/moq/discussions/1414#discussioncomment-6913884, a good point was made:

A warning would certainly be more visible, yet if WarningsNotAsErrors is provided via the package props, you can avoid the warning to ever be considered an error, even if warnings as errors is on.

Since SL provides only helpers and it's up to each package author to determine what to do with the sponsorship info, this would be mostly a documentation issue?

@kzu kzu added the documentation Improvements or additions to documentation label Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant